[PLT-1135] Alias these commands to each other so users don't have to remember which one is valid. #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfendell-labelbox
force-pushed
the
PLT-1135
branch
from
8845c51 to
7e88e90
Compare
|
Can you also do this one? |
adrian-chang
approved these changes
Jun 13, 2024
| @@ -23,6 +23,9 @@ def __init__(self, client, project_id: str, batch_ids: List[str], | |||
| Entity.Task.get_task(self.client, task_id) for task_id in task_ids | |||
| ] | |||
|
|
|||
| def wait_until_done(self, timeout_seconds: int = 300) -> None: | |||
| self.wait_till_done(timeout_seconds) | |||
There was a problem hiding this comment.
Might consider writing a unit tests (e.g.) copy and paste to ensure if they are changed accidentally, nothing breaks
adrian-chang
previously approved these changes
Jul 8, 2024
…remember which one is valid.
sfendell-labelbox
force-pushed
the
PLT-1135
branch
from
4458753 to
9e3a0c8
Compare
adrian-chang
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.